Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2E test coverage for Filters #4028

Merged
merged 7 commits into from
Dec 5, 2024
Merged

feat: E2E test coverage for Filters #4028

merged 7 commits into from
Dec 5, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Dec 2, 2024

Test coverage for adding a filter component, testing that the flag filtering works and components are arranged in the Public side in the right order.

Situation to test:

  • An editor can add the node and change the flagset
  • It is never visible publicly in the applicant-facing form
  • A Content or Notice component added to the branch of the Filter that is expected to be traveled down that is visible in the public form would confirm that logical navigation/auto-answering worked as expected

I am using the Material change of use flagset and have placed a Content in the Material change of use branch.

Ensured the Filter comp is not visible to public by relying on the await expect for the node before and after so we'd run into a timeout issue if something shows up.

@RODO94
Copy link
Contributor Author

RODO94 commented Dec 3, 2024

[E2E Tests] - Filters

Copy link

github-actions bot commented Dec 3, 2024

Removed vultr server and associated DNS entries

@RODO94 RODO94 marked this pull request as ready for review December 3, 2024 16:37
@RODO94 RODO94 requested a review from a team December 3, 2024 16:37
Copy link
Contributor

@jamdelion jamdelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of helper functions :)

@DafyddLlyr
Copy link
Contributor

Merged in @RODO94 's absence

@DafyddLlyr DafyddLlyr merged commit 3c0125f into main Dec 5, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the rory/e2e-filters branch December 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants